search

kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Changed CMAKE_ANDROID_STL_TYPE to shared #53

Closed MohitMaliFtechiz closed 1 year ago

MohitMaliFtechiz commented 1 year ago

Changed CMAKE_ANDROID_STL_TYPE to shared since it is not recommended to use static when we are using multiple dynamic libraries See conversation https://github.com/kiwix/java-libkiwix/issues/51.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (197777d) 92.38% compared to head (db79e70) 92.38%. Report is 1 commits behind head on main.

:exclamation: Current head db79e70 differs from pull request most recent head c314d48. Consider uploading reports for the commit c314d48 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================= Coverage 92.38% 92.38% Complexity 213 213 ========================================= Files 44 44 Lines 289 289 Branches 3 3 ========================================= Hits 267 267 Misses 19 19 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 1 year ago

@mgautierfr Can we merge this?