search

kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Do not read the library in readOnly mode. #72

Closed mgautierfr closed 10 months ago

mgautierfr commented 10 months ago

The readOnly argument of readFile is to put the loaded library in readOnly mode. Which kinda means "Do not write again what is loaded".

We don't want that for android as we want to save again our (potentially modified) library.

See kiwix/kiwix-android#3474

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f9dc43e) 92.38% compared to head (d109cc5) 92.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #72 +/- ## ========================================= Coverage 92.38% 92.38% Complexity 213 213 ========================================= Files 44 44 Lines 289 289 Branches 3 3 ========================================= Hits 267 267 Misses 19 19 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 10 months ago

@mgautierfr @MohitMaliFtechiz Who fixes this to release 1.0.1?

mgautierfr commented 10 months ago

Who fixes this to release 1.0.1?

I haven't made it the last time. So probably @MohitMaliFtechiz.

But any changes (changelog, version numbering here?,...) related to the release must be made in another PR.

BTW, we have this workflow which is triggered only when we create a release on github. But we don't have a 1.0.0 release. @MohitMaliFtechiz, how the previous release has been published ?

MohitMaliFtechiz commented 10 months ago

I haven't made it the last time. So probably @MohitMaliFtechiz.

@mgautierfr Last time @kelson42 published it on maven via workflow see here https://github.com/kiwix/java-libkiwix/actions/workflows/publish.yml

BTW, we have this workflow which is triggered only when we create a release on github.

Yes, you are right.

But we don't have a 1.0.0 release. @MohitMaliFtechiz, how the previous release has been published ?

We have release 1.0.0 published by @kelson42 see https://github.com/kiwix/java-libkiwix/releases

But any changes (changelog, version numbering here?,...) related to the release must be made in another PR.

Yes, we will make this on another PR, but before that, I am testing this PR to see if the issue is fixed or not. Allow me some time and i will test and review this PR.

mgautierfr commented 10 months ago

We have release 1.0.0 published by @kelson42 see kiwix/java-libkiwix/releases

Ho. I haven't found the tab on github UI so I assume there was no release. Sorry about the noise.

MohitMaliFtechiz commented 10 months ago

@mgautierfr The bug is resolved now :tada: :tada: , now it is properly saving the data everytime.