kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Release 1.0.2 #79

Closed kelson42 closed 9 months ago

kelson42 commented 11 months ago

@mgautierfr I have tried to remove getSize() to support latest version of libzim, but it seems we have other problems. Could you please have a look please?

mgautierfr commented 10 months ago

@MohitMaliDeveloper, The CI is failing at Install dependencies step. The error message is

This version only understands SDK XML versions up to 2 but an SDK XML file of version 3 was encountered. This can happen if you use versions of Android Studio and the command-line tools that were released at different times.

Then a backtrace about 33x not being a number (I agree with that, but don't get from where 33x comes from). And then plenty of other error message (I let you read them at https://github.com/kiwix/java-libkiwix/actions/runs/7232262963/job/20270039324)

Do you have an idea ?

MohitMaliFtechiz commented 9 months ago

@mgautierfr CI is failing on compile project, let me check what going on here.

mgautierfr commented 9 months ago

The CI is failing of the compile project, but with make[2]: *** No rule to make target 'libkiwix.so', needed by 'libkiwix_wrapper.so'. Stop. (line 239).

This is because the Install Dependencies has failed (without being an error to stop the CI, which is another problem).

MohitMaliFtechiz commented 9 months ago

@mgautierfr Thanks this is the problem with the version of libkiwix we have put here 13.0.0-1. This version archive is available on the https://download.kiwix.org/release/libkiwix/. But internally it has version 13.0.0 as shown in the below image. I think this is obvious because libkiwix has not any release of 13.0.0-1 that why inside the folder it has the 13.0.0 version.

Or somehow there are any differences in these .so files of different versions(13.0.0 and 13.0.0-1)?

Screenshot from 2024-01-18 18-03-39

This is because the Install Dependencies has failed (without being an error to stop the CI, which is another problem).

Thanks, I have improved this now CI is failing on the Install Dependencies task with error message, see https://github.com/kiwix/java-libkiwix/actions/runs/7570603587/job/20616281022?pr=79#step:4:3514.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (38373f9) 92.54% compared to head (2714211) 92.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #79 +/- ## ============================================ - Coverage 92.54% 92.51% -0.03% + Complexity 219 218 -1 ============================================ Files 45 45 Lines 295 294 -1 Branches 3 3 ============================================ - Hits 273 272 -1 Misses 19 19 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgautierfr commented 9 months ago

Version 13.0.0-1 means it is the second build (the first one being 13.0.0) of the release 13.0.0. We do this when we change the dependencies (for example, libzim) but we don't change the release of the project (libkiwix).

We should use the -n to download the archive but don't use it once we have the archive as internal files inside it will not have it.

MohitMaliFtechiz commented 9 months ago

@mgautierfr Thanks, I was not aware of this. Now I understand this properly, I am making changes according to this.

MohitMaliFtechiz commented 9 months ago

@mgautierfr I have modified the code to adapt this change, and updated the libkiwix version to 13.0.0-1.

mgautierfr commented 9 months ago

Thanks for the fix !