search

kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Do not keep localRef to object once it is added to an array. #81

Closed mgautierfr closed 9 months ago

mgautierfr commented 9 months ago

Fix #80

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4a8e966) 92.51% compared to head (3f58dc2) 92.51%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================= Coverage 92.51% 92.51% Complexity 218 218 ========================================= Files 45 45 Lines 294 294 Branches 3 3 ========================================= Hits 272 272 Misses 19 19 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mgautierfr commented 9 months ago

@MohitMaliFtechiz Can you test this on your side ?

MohitMaliFtechiz commented 9 months ago

@mgautierfr Thanks. I have tested it and now it is working fine without any crash on Android 7(API level 24) there is no locaRef error anymore.

mgautierfr commented 9 months ago

Good. I'm merging so.