search

kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Wrap new methods `migrateBookmarks` and `getBestTargetBookId` of libkiwix #85

Closed mgautierfr closed 6 months ago

mgautierfr commented 7 months ago

This PR is in Draft as it wrap a feature in libkiwix not yet released. Once libkiwix is release, we have still have to change gradle script to use it and then we should be good.

Fix #84

kelson42 commented 6 months ago

@mgautierfr I have updated the code base to rely on libkiwix 13.1.0 and rebased this PR.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.85%. Comparing base (1aeb144) to head (fa44690).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #85 +/- ## ============================================ + Coverage 92.51% 92.85% +0.34% - Complexity 218 232 +14 ============================================ Files 45 46 +1 Lines 294 308 +14 Branches 3 3 ============================================ + Hits 272 286 +14 Misses 19 19 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.