Closed MohitMaliFtechiz closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.23%. Comparing base (
40f17fd
) to head (ad78cf2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@MohitMaliFtechiz All checkd pass, ready to merge?
@MohitMaliFtechiz BTW what the diadvantage if we keep 24 as minimum? Please also have a look to CI log there is far too many errors and warnings ro my taste.
@MohitMaliFtechiz BTW what the diadvantage if we keep 24 as minimum?
There is no any disadvantage to keeping the 24 as the minimum API level. I have changed the minimum API level to 24.
Please also have a look to CI log there is far too many errors and warnings ro my taste.
@kelson42 I have fixed the warnings reported by the gradle. Apart from these gradle warnings, there are now cpp
deprecations warnings showing on the CI logs. I think @mgautierfr better know about this, maybe these are necessary for compiling. However, we have the ticket for these warnings https://github.com/kiwix/java-libkiwix/issues/92, so we can move forward with this PR.
@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI?
@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI?
@kelson42 You mean warnings(Right)? since Gradle automatically fails the task when there is an error. We can add the lint
here which checks the project's errors and warnings. Apart from this, should we also fail the build when there is a deprecation warning in the cpp
code?
No, I mean java exceptions
@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI? No, I mean java exceptions
@kelson42 I have added the lint to our project which will fail the CI if any potential error is detected(e.g. gradle and code-related errors).
Fixes #90
io.github.gradle-nexus:publish-plugin
to2.0.0
.org.jetbrains.kotlin:kotlin-gradle-plugin
to1.9.20
.