kiwix / java-libkiwix

Libkiwix binding for Java & Kotlin
https://central.sonatype.com/artifact/org.kiwix/libkiwix
GNU General Public License v3.0
3 stars 4 forks source link

Added support for SDK 34. #97

Closed MohitMaliFtechiz closed 6 months ago

MohitMaliFtechiz commented 6 months ago

Fixes #90

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.23%. Comparing base (40f17fd) to head (ad78cf2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ========================================= Coverage 93.23% 93.23% Complexity 237 237 ========================================= Files 47 47 Lines 325 325 Branches 3 3 ========================================= Hits 303 303 Misses 19 19 Partials 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 6 months ago

@MohitMaliFtechiz All checkd pass, ready to merge?

kelson42 commented 6 months ago

@MohitMaliFtechiz BTW what the diadvantage if we keep 24 as minimum? Please also have a look to CI log there is far too many errors and warnings ro my taste.

MohitMaliFtechiz commented 6 months ago

@MohitMaliFtechiz BTW what the diadvantage if we keep 24 as minimum?

There is no any disadvantage to keeping the 24 as the minimum API level. I have changed the minimum API level to 24.

Please also have a look to CI log there is far too many errors and warnings ro my taste.

@kelson42 I have fixed the warnings reported by the gradle. Apart from these gradle warnings, there are now cpp deprecations warnings showing on the CI logs. I think @mgautierfr better know about this, maybe these are necessary for compiling. However, we have the ticket for these warnings https://github.com/kiwix/java-libkiwix/issues/92, so we can move forward with this PR.

kelson42 commented 6 months ago

@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI?

MohitMaliFtechiz commented 6 months ago

@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI?

@kelson42 You mean warnings(Right)? since Gradle automatically fails the task when there is an error. We can add the lint here which checks the project's errors and warnings. Apart from this, should we also fail the build when there is a deprecation warning in the cpp code?

kelson42 commented 6 months ago

No, I mean java exceptions

MohitMaliFtechiz commented 6 months ago

@MohitMaliFtechiz Can you please configure that gradle/tests to fail if we have exceptions in CI? No, I mean java exceptions

@kelson42 I have added the lint to our project which will fail the CI if any potential error is detected(e.g. gradle and code-related errors).