Closed MohitMaliFtechiz closed 10 months ago
@kelson42, @gouri-panda We have successfully uploaded a dummy APK via actions/upload-artifact
https://github.com/kiwix/kiwix-android-custom/actions/runs/6494812009. Now this PR is ready for review.
@kelson42 You can download the released APk from https://github.com/kiwix/kiwix-android-custom/actions/runs/6494812009 and upload it on Play console.
@MohitMaliDeveloper I don't think this PR is relevant anymore!
@gouri-panda What about the package name not found on Play Store
error? which we were facing for new apps. If we upload a bundle via CD, play store allow us to upload it?
@MohitMaliDeveloper I thought we had reached the conclusion that we can't do that without uploading the apk/bundle the first time manually.
@gouri-panda indeed, please read the ticket
@MohitMaliDeveloper I thought we had reached the conclusion that we can't do that without uploading the apk/bundle the first time manually.
Yes, we need to manually upload the bundle for the first time but to avoid manually generating the bundle every time for new apps we have implemented this, it will automatically build and upload a bundle for new apps on CD. We only need to add the "new": true
in the info.json
file and it will generate the bundle for us, it would be easier for us and does not depend on anyone.
@kelson42 @MohitMaliDeveloper Ok. If you think it would work then great! I confused about that i researched that a bit and I did think it was impossible. My first question is why do we need a dummy apk to upload(in this pr we're uploading the apk)? Shouldn't we directly upload the valid bundle? And how should we test this with the new app? We've some pending app for uploading. Should we try there?
@kelson42 @MohitMaliDeveloper Ok. If you think it would work then great! I confused about that i researched that a bit and I did think it was impossible.
Can you please share research if we can directly upload the bundle on Play Store without having the package name not found
error.
My first question is why do we need a dummy apk to upload(in this pr we're uploading the apk)?
No, we are uploading bundle not apk in this PR. We have this dummy bundle to upload on playstore for new apps as we had facing the package name not found
error on CD while publishing the DWDS app.
@gouri-panda Do you have the feeling this PR does not do what the ticket request? Otherwise would really like to see this PR reviewed.
@gouri-panda Do you have the feeling this PR does not do what the ticket request? Otherwise would really like to see this PR reviewed.
@kelson42 Yes, sort of! In order to review this we need to test this in our new app. if you give us permission to test this with our new apps.
There is nothing related to the size restriction either on the ticket or PR description, @gouri-panda what are you talking about exactly?
This PR is ready for almost 3 weeks and nothing seems to be wrong. Will merge on Sunday except something clearly wrong is identified.
@MohitMaliDeveloper This PR should be:
main
develop
branch@kelson42 Changes are done as you requested.
Fixes #109
publish.yml
to store a dummy bundle in workflow, so we need to add"new": true
in the info.json file.README.md
file to document this.