kiwix / kiwix-android-custom

Necessary data/tools for the Android custom apps
https://play.google.com/store/apps/developer?id=Kiwix+Team
GNU General Public License v3.0
15 stars 10 forks source link

Disables TTS (read aloud) for DWDS custom app #117

Closed gremid closed 1 year ago

gremid commented 1 year ago

The results of the builtin text-to-speech service are not good enough at the moment, so we would prefer to disable this feature until we found a way to control which parts of a DWDS article are read and in which order.

kelson42 commented 1 year ago

@gouri-panda Do we have any feature allowing to disable TTS based on info.json?!

gouri-panda commented 1 year ago

@kelson42 Yes, we do have that feature.

kelson42 commented 1 year ago

@kelson42 Yes, we do have that feature.

Why is that not documented in the README.md? Do we have other options of that kind?

gouri-panda commented 1 year ago

Why is that not documented in the README.md?

I'll add that.

Do we have other options of that kind?

https://github.com/kiwix/kiwix-android/blob/1b879006958db11b6070c54013c8e7da126ba7da/buildSrc/src/main/kotlin/custom/CustomApps.kt#L47-L54

kelson42 commented 1 year ago

Why is that not documented in the README.md? I'll add that

Thanks! It's really important that all possible options/properties which can be put in the info.json are clearly explained and understandable.

gouri-panda commented 1 year ago

@gremid Thank you! But unfortunately, we can't merge this at the moment. But I've pushed your code to the dwds tag.

kelson42 commented 1 year ago

@gouri-panda Please open a PR for the dwds branch. Releasing from a tag which is not on main is not allowed and should stay exceptional.

gremid commented 1 year ago

@gouri-panda @kelson42 When will the changes be published then?

gouri-panda commented 1 year ago

@gremid After https://github.com/kiwix/kiwix-android/pull/3526, I think we're good to merge. Also, we're already published your change into play store https://github.com/kiwix/kiwix-android-custom/actions/runs/6795725744 .