Closed gremid closed 1 year ago
@gouri-panda Do we have any feature allowing to disable TTS based on info.json?!
@kelson42 Yes, we do have that feature.
@kelson42 Yes, we do have that feature.
Why is that not documented in the README.md? Do we have other options of that kind?
Why is that not documented in the README.md?
I'll add that.
Do we have other options of that kind?
Why is that not documented in the README.md? I'll add that
Thanks! It's really important that all possible options/properties which can be put in the info.json are clearly explained and understandable.
@gremid Thank you! But unfortunately, we can't merge this at the moment. But I've pushed your code to the dwds
tag.
@gouri-panda Please open a PR for the dwds branch. Releasing from a tag which is not on main is not allowed and should stay exceptional.
@gouri-panda @kelson42 When will the changes be published then?
@gremid After https://github.com/kiwix/kiwix-android/pull/3526, I think we're good to merge. Also, we're already published your change into play store https://github.com/kiwix/kiwix-android-custom/actions/runs/6795725744 .
The results of the builtin text-to-speech service are not good enough at the moment, so we would prefer to disable this feature until we found a way to control which parts of a DWDS article are read and in which order.