search

kiwix / kiwix-android-custom

Necessary data/tools for the Android custom apps
https://play.google.com/store/apps/developer?id=Kiwix+Team
GNU General Public License v3.0
14 stars 9 forks source link

Improve Google Play update script to allow updates without content change #67

Open kelson42 opened 7 years ago

kelson42 commented 7 years ago

From @mhutti1 on December 30, 2016 18:9

upload-apk.py should be updated to allow for uploading APKs with an existing expansion. For now this operation can only be achieved using the Google Play Admin Web UI.

Copied from original issue: kiwix/kiwix#407

kelson42 commented 7 years ago

From @mhutti1 on December 30, 2016 18:9

@kelson42 as this requires an API key to test its not really suitable for GCI.

kelson42 commented 7 years ago

@mhutti1 AFAIK update-play-store.py is only there to update the play store meta data, not to upload APK. So it is not clear to me which problem this ticket should solve.

kelson42 commented 7 years ago

From @mhutti1 on December 31, 2016 11:1

@kelson42 my mistake I meant upload-apk.py

kelson42 commented 7 years ago

@mhutti1 You mean, you meant update-play-store.py?

mhutti1 commented 7 years ago

This should be implemented into our new build system however it ends up working.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 4 years ago

@mhutti1 What would be the real advantage of doing so? save 15MB (size of the kiwix app) of bandwidth for the user?

macgills commented 4 years ago

uploading APKs with an existing expansion. this is so developers do not have to go into the play console and manually associate our expansion files with each new apk, there are a host of gotchas when working with expansion files. This functionality is supported by gradle play publisher

kelson42 commented 4 years ago

OK, I see now that I have understood the ticket upside down: upload content without code change.

kelson42 commented 4 years ago

@macgills great if we can do that almost out of the box. This sounds an important feature indeed.

kelson42 commented 4 years ago

@macgills From what I have heard recently, this is not so easy to do (anymore)? What is the status here?

macgills commented 4 years ago

We couldn't use GPP for custom uploads so it is not implemented, it is possible afaik but we would probably need to add another config file on the root of kiwix-android-custom to offer options to the GitHub action on how it builds.

The Action uploads the artifact in draft and at that point the attached obb can be manually selected to be an older version if we so wish, obviously would be better if it were automatic

kelson42 commented 4 years ago

@macgills Thx, I descope it from the milestone for now.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 1 year ago

Seems to be a topic for kiwix/Kiwix-android-custom

kelson42 commented 2 months ago

@MohitMaliDeveloper Is that not something automatically allowed now with bundle?