search

kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
822 stars 442 forks source link

Implement full text search #1324

Open gilcu3 opened 4 years ago

gilcu3 commented 4 years ago

Describe the bug

Option for full text search is missing from settings since version 2.4 (version 2.2 works). Zim files are recent (2018). When searching terms, it clearly only searches in titles.

Expected behavior

Full text should work as in previous versions.

Steps to reproduce the behavior:

  1. Search a term

    Environment

    • Version of Kiwix Android : 2.5.1
    • Device : Redmi Note 6 Pro
    • OS version : Android Pie
kelson42 commented 4 years ago

I think fulltext should work differently from the suggestion system, like with kiwix-serve. Mixing title search and fulltext search does not seem to be a good approach to me.

gilcu3 commented 4 years ago

I understand, but the problem is usually when one is making a search, and the term doesn't appear in the title, there is no way to find the corresponding article. In version 2.2 it was possible with Full Text Search enabled.

gilcu3 commented 4 years ago

Just to wrap up, full text search and title search were mixed in version 2.2, but from version 2.4 and up to version 2.5.1 (current) is it possible to do a full text search?

kelson42 commented 4 years ago

Like you can see the ticket is still open.

gilcu3 commented 4 years ago

Like you can see the ticket is still open.

yeah :(, but shouldn't old implementation work?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

AxelBoldt commented 4 weeks ago

I think this would be an extremely useful feature to have; it's sad that the issue has not been assigned to anyone. Do we know why fulltext search stopped working in version 2.4?

kelson42 commented 4 weeks ago

I don't remember the details, but AFAIK it was not working well, probably it was too slow. We will bring it back, but this will not be done in the few next minor releases.