search

kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
899 stars 450 forks source link

Night mode inverts also picture colors on Android 4.2 #153

Closed kelson42 closed 6 years ago

kelson42 commented 7 years ago

Tested on BitBar with a 

    Samsung Galaxy S III Mini GT-I8200L
    ANDROID
    Dual-core 1.2 GHz / ARMv7
    1024 MB
    WVGA (800 x 480)
mhutti1 commented 7 years ago

Do you mean 4.2?

kelson42 commented 7 years ago

@mhutti1 yes

dbedrenko commented 7 years ago

Any status update on this? Otherwise, could I get a hint of where in the code I should even look to find the problem? Should I be fixing this in the Android port or in the "core" libs?

I just got a 128GB microSD JUST so that I could have wikipedia with pictures, and it's useless when they are inverted.

kelson42 commented 7 years ago

@dbedrenko Which version of Android do you have? AFAIK it works but maybe not with quite older versions of Android...

dbedrenko commented 7 years ago

Full specs:

Android v4.2.2
Model: Galaxy Tab 2, GT-P5100
Kernel: v3.0.31

Kiwix: v2.2 Build 53

I bought this tablet exclusively for reading, so you can bet your chops I'm motivated to find a fix for this :)

mhutti1 commented 7 years ago

It seems the problem is that our current solution https://github.com/kiwix/kiwix-android/blob/master/app/src/main/java/org/kiwix/kiwixmobile/ZimContentProvider.java#L457 does not work on earlier android versions I assume because of the webkit version. We need to come up with an alternative to invert the image colours that does.

kelson42 commented 6 years ago

I suspect this bug is not really easy to fix and as Android 4.2 does only represent 5% of the overall Android audience I propose to close it as WONTFIX.