search

kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
890 stars 447 forks source link

Tabs previews in Tab Switcher doesn't change. #1691

Closed ajuancer closed 4 years ago

ajuancer commented 4 years ago

Tabs previews in Tab switcher when dark theme is active doesn't change. When we're in the Tab Switcher of the app, and the app is working with the dark theme, the preview for each opened tab continues being the normal one. The background is white and hyperlinks are in blue. The only change is shown if the article preview contains an image, in that case, the image will have inverted colors.

Expected behavior. There should be a continuity with the theme. If the dark theme is active, previews also should be in that theme.

Steps to reproduce the behavior:

  1. Activate Dark theme is your phone. This can be done in the developer settings or through the Kiwix's own settings.
  2. Open the app
  3. Open the TabSwitcher
  4. See error

Environment

example

macgills commented 4 years ago

We will be overhauling the rendering in #1411 so I think this would be best addressed then instead of fixing now and reimplementing then.

Thank you for the report

kelson42 commented 4 years ago

Closing, because basically a duplicate.