Re-enable tests for ZimManageActivity

kiwix / kiwix-android

Kiwix for Android

https://android.kiwix.org

GNU General Public License v3.0

826 stars 443 forks source link

Re-enable tests for ZimManageActivity #1755

Closed macgills closed 1 year ago

macgills commented 4 years ago

Type of Test

[ ] Unit Test
[x] UI Test

Current Status of the tests On CI this test would sometimes fail. Clicking on the book would not start the download and not show the stop_download button. Operating theory is that a system dialog was interfering at times, preventing view interaction

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 1 year ago

@gouri-panda What is the status of this bug? This actual? If "yes", could we reactivate the test?

gouri-panda commented 1 year ago

@kelson42 We can re-write or refactor the test :)

kelson42 commented 1 year ago

We will postpone this ticket to 3.8.0 because it implies a larger rewriting of onlinelibraryfragment…. And this part will probably be significantly revamped in 3.8.0 because of OPDS support.

MohitMaliFtechiz commented 1 year ago

hi @gouri-panda , @kelson42

Since this ticket is very old and now the ZimManageActivity is not there in our project. Can you please tell me, what is this activity do in the past.
According to this PR i think this activity is doing the downloading ZIM files and language related part (Tell me if i had understand this wrong).
if i'm correct , then we have already written test cases for DownloadTest , LanguageTest , InitialDownloadTest these test making sure the online content is loaded or not which i think we are testing in ZimManageActivityTest.

kelson42 commented 1 year ago

@gouri-panda This is a question for you.

gouri-panda commented 1 year ago

@MohitMaliFtechiz Sorry for the late reply! Yes! you are correct. We refactored this class from ZimManageActivity to OnlineLibraryFragment long back. If you can see ZimManageActivityTest we deleted/commented on the whole class. I think that's why we created this ticket to secure these tests.

kelson42 commented 1 year ago

@MohitMaliFtechiz Can you handle it?

MohitMaliFtechiz commented 1 year ago

On CI this test would sometimes fail. Clicking on the book would not start the download and not show the stop_download button. Operating theory is that a system dialog was interfering at times, preventing view interaction

@kelson42 , @gouri-panda , The purpose of this test is to start and stop the download of ZIm files , which we are already doing in (DownloadTest , InitialDownloadTest) , so we can close this ticket.

Since now ZimManageActivityTest and ZimManageRobot classes are unused we should remove these classes.