search

kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
890 stars 446 forks source link

Add an option for Open New Tab and Close All Tabs in tabs section menu #1939

Open yashk2000 opened 4 years ago

yashk2000 commented 4 years ago

Is your feature request related to a problem? Please describe.

Currently, the only way to open a new and close all tabs in the tabs section is by pressing on the buttons ment for those actions. It would be good to provide these options in the menu too, like chrome does.

Describe the solution you'd like

Provide the options for opening a new tab and closing all tabs in the menu too to increase the accessibiltiy of these options which will enahce the UX of the app.

Additional context

I would like to work on this issue.

kelson42 commented 4 years ago

I don't see any added value to add a new "Open a new tab" menu entry. I'm a bit more open about a "Close all tabs" menu entry... Needs to be confirmed.

yashk2000 commented 4 years ago

Opening a new tab option will also enhance the UX. Chrome also provides the option to open a new tab from the menu as well as a plus button in the tabs section.

4shutosh commented 4 years ago

Opening a new tab from Menu requires two touches (current Feature requested) Opeinng a new tab from TabSwitcher also requires two touches. I personally see no enhancement because of this feature

Chrome offers this feature because every tab usually consists of different content. Generally, the user will not open a new tab to open the same file.(But to read diiferent articles simulatanously) which will require opening Tab Switcher. If the user wants to open another zim file it can be done using Library option.(from Menu Itself)

The New Tab menu option will be useful once we support multiZim, but at this point, I think it is an unnecessary increase in size of menu.

Generally, the user will not open a new tab to open the same file.(But to read diiferent articles simulatanously) which will require opening Tab Switcher.

This being said. I think Close All tab is also not required as of now, adding this option in menu will impact negative usage. The Tab Switcher View already is capable enough of doing these actions.

yashk2000 commented 4 years ago

Opening a new tab from Menu requires two touches (current Feature requested) Opeinng a new tab from TabSwitcher also requires two touches. I personally see no enhancement because of this feature

The number of touches is the same, but the position of touches is different. If the options are present in the menu, you basically click twice in almost the same place which makes for better UX. If you go to the tab switcher, you first click on the top right corner then the top left corner. Similarly for the close all tabs, you click in two very different places. Having to click twice in almost the same place is definitely a better UX than clicking in two places which are a bit far from each other.

The New Tab menu option will be useful once we support multiZim, but at this point, I think it is an unnecessary increase in size of menu.

Since the feature has to be implemented at that time, no harm in implementing it now itself :)

The Tab Switcher View already is capable enough of doing these actions.

Agreed, but I am also focusing on improving the UX of the app.

yashk2000 commented 4 years ago

Since this issue is already a question, I'm not yet working on it right now. I'm waiting for the decision made by the other maintainers and will proceed however they see fit.

Same for #1940, I'll proceed according to the decision made by the maintainers.

yashk2000 commented 4 years ago

@macgills "New Tab" is not to be there, but what about the "Close All Tabs"? Should that be done or should I close this issue?

macgills commented 4 years ago

I'll leave it to @kelson42 to decide on that front

yashk2000 commented 4 years ago

@kelson42 should I proceed with adding a Close All Tabs option to the menu?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.