macgills
commented
4 years ago "Delete 10 selected history items?"
That should be ruled out because we want to avoid pluralised strings eg "Delete 1 item" "Delete 2 items" as supporting this across all languages is a bit complicated.
"Delete all history?"/"Clear all history?"
This seems ambiguous to me because we delete the "currently viewed" history, ie all history if "showAllHistory" is toggled or "current book history" if it is not and to communicate that to a user I feel gets too wordy and more likely to confuse.
"Delete selected history?"
Is the only one that has my support right now but I could hear arguments
Frans-Lukas
Is your feature request related to a problem? Please describe.
When deleting history items from the history view, the confirmation dialog always says "Delete history?". I argue that this is not specific enough because there is a difference of deleting all items, or just the selected items which should be made more clear in the confirmation dialog.
Describe the solution you'd like
When trying to delete all items it should ask "Delete all history?"/"Clear all history?" and when trying to delete the selected history items it should ask "Delete selected history?"/"Delete 10 selected history items?"
Describe alternatives you've considered
Keep it as is as you can see that you have selected items, however it does not hurt to be too specific. I think some distinction should be made between the two dialogs.
Additional context
Current dialog text:
Deleting all items
Deleting selected items