search

kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
824 stars 442 forks source link

Replace Widget Intents with Navigation Deep Links #2372

Open macgills opened 3 years ago

macgills commented 3 years ago

Is your feature request related to a problem? Please describe. The search widget works unpredictably and confusingly

Describe the solution you'd like Use Navigation Deep Links to wire our widget to our search destination

macgills commented 3 years ago

2399 is proposing the deletion of the widget, @kelson42 I think we need to reach a decision on that ticket to prevent working on a thing that will not exist

kelson42 commented 3 years ago

I don't have made a decision here and still not sure about what to do. I would like to give us a bit more time. Can we just postpone things? Maybe in the meantime we can just deactivate (no code suppression) the search widget (that would allow us to know if users complain about this feature missing).

macgills commented 3 years ago

I can remove our code that provides the widget, I imagine on an update that that would remove the widget if a user has it configured? I'd probably need to do some local experiments, widgets are weird as they are not a part of the app, they are RemoteViews.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.