search

kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
890 stars 447 forks source link

Library search should diacritics insensitive #2638

Open gouri-panda opened 3 years ago

gouri-panda commented 3 years ago

looks like if you search something in the online library, the selected language does not apply so i choose french in languages... but if I search "Wikipedia" I don't get (first) the result (zim books) in french

kelson42 commented 3 years ago

@gouri-panda Thx for opening the ticket... this is quite a critical bug (regression) as it almost remove the ability to find new books to download in the user language.

kelson42 commented 3 years ago

For a dummy research "Wikipedia" which should give books in each language, we see no entry "Selected languages:" but only "Other languages" with basically all the content of zero value for the user. Screenshot_20210408-124258.png

gouri-panda commented 3 years ago

Here we are searching "Wikipedia" instead of "Wikipèdia". So we don't get the expected result.

kelson42 commented 3 years ago

This problem should be fixed automatically if we use OPDS in place of custom library_zim.xml handling.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 2 years ago

This should be automatically fixed by using latest libkiwix and OPDS library.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

kelson42 commented 1 year ago

This will be fixed within the « Room » project, by just using the libkiwix12 to handle local and remote library. @gouri-panda nothing special to do it first.

gouri-panda commented 1 year ago

@kelson42 Sure!