kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
826 stars 443 forks source link

Still a few accessibility issues #3873

Open kelson42 opened 1 month ago

kelson42 commented 1 month ago

image

MohitMaliFtechiz commented 1 month ago

@kelson42 These issues are known, and I had updated the information for these views in accessibility fixes PR. Also, we had suppressed these issues in our test cases so that they would not affect the test cases.

The content labeling issue is showing because there is the same content description on multiple views, particularly on the recycler view items. Here multiple views can have the same content description.

The Implementation can not be fixed due to it is inside the library.

The Low contrast issue is occurring because some views are behind the navigation drawer.

Screenshot from 2024-06-11 11-03-02 Screenshot from 2024-06-11 11-02-07

For the Touch target issue it is advancing to change the width of the text_view_device_name but it has the wrap content width so it will automatically adjust its width when it gets the value. It is showing this warning due to there is no text at the time of checking.

Screenshot from 2024-06-11 11-04-19

For the other touch target issue it is inside the library and we are not using that text.

Screenshot from 2024-06-11 11-04-54

The last touch target issue we already placed a fix for it, see the below video.

https://github.com/kiwix/kiwix-android/assets/34593983/1053f1f1-ada5-4ec8-a9b4-cc0f5aabd09f

kelson42 commented 1 month ago

The content labeling issue is showing because there is the same content description on multiple views, particularly on the recycler view items. Here multiple views can have the same content description.

@MohitMaliFtechiz None of them should be the same! Why they are the same in the language selection?

kelson42 commented 1 month ago

The Low contrast issue is occurring because some views are behind the navigation drawer.

This is not normal that the PlayStore is fooled by this. please make proposal to fix. maybe we should stop this semi-transparency? or make it atromger?