Fixed: The UI showing incorrect colors in night mode.

kiwix / kiwix-android

Kiwix for Android

https://android.kiwix.org

GNU General Public License v3.0

892 stars 448 forks source link

Fixed: The UI showing incorrect colors in night mode. #3998

Closed MohitMaliFtechiz closed 1 month ago

MohitMaliFtechiz commented 1 month ago

Fixes #3991

Light Mode	Night Mode

Apart from these, all other views use the Android standard colors in our project.

Fixed an issue where the CI was sometimes failing due to an unknown reason related to the OverflowMenuButton (the three-dot default Android button) width. See this workflow https://github.com/kiwix/kiwix-android/actions/runs/11124822272/job/30911192279?pr=3998.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.09%. Comparing base (701c9c1) to head (2b796b0). Report is 4 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3998 +/- ## ============================================ - Coverage 58.22% 58.09% -0.14% + Complexity 1601 1598 -3 ============================================ Files 314 314 Lines 13050 13050 Branches 1657 1657 ============================================ - Hits 7598 7581 -17 - Misses 4344 4364 +20 + Partials 1108 1105 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kelson42 commented 1 month ago

@MohitMaliDeveloper What is the status here? Have all the colors cleanuped so we have clear light/dark modes without custom colors?

MohitMaliFtechiz commented 1 month ago

@MohitMaliDeveloper What is the status here? Have all the colors cleanuped so we have clear light/dark modes without custom colors?

@kelson42 Yes.

I was waiting for your reply on https://github.com/kiwix/kiwix-android/issues/3736#issuecomment-2363571129, I have put the screenshots of the UI of donation popup in the PR description, if it looks okay to you than this PR is ready for review.

kelson42 commented 1 month ago

@MohitMaliDeveloper What is the status here? Have all the colors cleanuped so we have clear light/dark modes without custom colors?

@kelson42 Yes.

I was waiting for your reply on #3736 (comment), I have put the screenshots of the UI of donation popup in the PR description, if it looks okay to you than this PR is ready for review.

Please don't use any custom colors at all. Rely on default themes. I will treat the donate box separatly.

MohitMaliFtechiz commented 1 month ago

Please don't use any custom colors at all. Rely on default themes.

@kelson42 We are not using any custom colors in this, we are using the default theme color in our project. In this PR I have removed the custom colors from the project.

I will treat the donate box separately.

Okay, I have created a separate PR for this https://github.com/kiwix/kiwix-android/pull/4012.