search

kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
906 stars 450 forks source link

Many problems at first side loading of a ZiM file #4067

Closed kelson42 closed 2 weeks ago

kelson42 commented 3 weeks ago

Image

Here the points:

MohitMaliFtechiz commented 3 weeks ago

It seems the message in the screenshot is displayed only once at first. I wonder if it would not be best to just show the usual one "do you want to move or copy..." and write an explanation in the help.

@kelson42 good idea, because now, we have improved the copy/move dialog message(https://github.com/kiwix/kiwix-android/pull/4069) so users can better understand this. Also, we will add a cancel button so that users have more control over this functionality.

Ater closing copy, it goes straight to copy... but actually it should propose the chooser of storage (I have a SD card)

The copied ZIM file will go into the current selected storage https://github.com/kiwix/kiwix-android/issues/3941#issuecomment-2284446727 (I remember I had a conversation about this with you). For example:- if the user has selected "internal storage" in the settings screen the file will go into the "internal storage", the same for the SD card. If there is not enough storage available it will ask to configure the storage(for example if there is not enough storage in internal storage it asks to configure the storage to an SD card).

But thinking about your opinion, it is better to provide the option for selecting the storage before copy/move since it will let users directly copy/move the files in their wanted storage without configuring the storage from settings.

Edited: @kelson42 Do you want to show the chooser of storage once at the initial copy/move operation or do you want to show it on every copy/move operation? To me you want only to show the chooser of storage at the initial copy/move operation, please correct me if I am wrong.

kelson42 commented 3 weeks ago

@MohitMaliFtechiz Thx, you get things right. The storage chooser should only be displayed once at start (and only if there is a chiice to make).

kelson42 commented 3 weeks ago

@MohitMaliFtechiz Once CI green, please rebase and merge and release for testing in PS

MohitMaliFtechiz commented 2 weeks ago

@MohitMaliFtechiz Once CI green, please rebase and merge and release for testing in PS

@kelson42 I can not directly merge the PR, it needs your approval. The PR is now ready for review with all the videos and screenshots.

MohitMaliFtechiz commented 2 weeks ago

@kelson42 The application has been released in testing on PS. https://github.com/kiwix/kiwix-android/actions/runs/11837938150/job/32985980177.