search

kiwix / kiwix-android

Kiwix for Android
https://android.kiwix.org
GNU General Public License v3.0
867 stars 443 forks source link

Create a custom Toast View #456

Closed RajaVamsi11 closed 5 years ago

RajaVamsi11 commented 6 years ago

Is it a ?

Bug Report

Step 2 : What is your environment ?

Step 3: Describe the problem:

When a user click an article in the list of Wikipedia articles in online fragment,if the phone has no sufficient memory to down load , Toast message will be produced along with snackbar. the background colour of the toast message and the online fragment background colour resembles.It looks somewhat weird. My idea is to create a customized toast view for that toast message.(Changing background color and other changes)

Would you like to work on it? Yes

@mhutti1 @srv-twry your reviews please?

brijeshshah13 commented 6 years ago

@RajaVamsi11 Can you please specify your phone details and android version because for me it's working all fine. Here:

screenshot_20180218-211521

RajaVamsi11 commented 6 years ago

It is in emulator @brijeshshah13 . I think the problem is in emulator. I am closing this issue.

brijeshshah13 commented 6 years ago

@RajaVamsi11 Still can you please post the Android version so that we can confirm that it is infact the issue of the emulator.

RajaVamsi11 commented 6 years ago

Android version 8.1.0 (Emulator)

mhutti1 commented 6 years ago

Lets keep this open for a bit and see if anyone can reproduce unless you have specific information that leads you to think this is the emulator.

ghost commented 6 years ago

I don’t have the screen shot but when I was working earlier today this happened, although I’ll redo it and get a screen cap if I see if the bug gets reproduced again.

RajaVamsi11 commented 6 years ago

ok..lets wait and see @mhutti1

cmeher196 commented 6 years ago

@RajaVamsi11 hey is this issue still open?? or issue is fixed?? if not then can i work on it?

MayankChuriwal commented 6 years ago

@cmeher I guess the issue was with the emulator itself as I have checked it on various phones with various sizes and different android versions but it looks good to me. Open if someone gets this bug on an actual device.

dr0pdb commented 6 years ago

@cmeher196 I would suggest you please go through the above discussion.

RajaVamsi11 commented 6 years ago

@cmeher196 The issue was with emmulator itself.It works fine in actual devices.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

mhutti1 commented 5 years ago

Closing this as we should use the standard android toast imo.