Closed savannahar68 closed 6 years ago
@savannahar68 The feature request is good to add. what do you say @srv-twry @abdulwd @brijeshshah13
@savannahar68 LGTM.
@RajaVamsi11 @srv-twry Yes sir,almost done, ill send a PR soon, should I add fastscroll to all the listviews, or only to the Language section,becuase as mentioned in another issue that library section will be modified to recyclerview .
@savannahar68 Please don't call me sir :smile: I would wait for @mhutti1 to suggest what to do in this issue and also in the RecyclerView issue. I created that issue and the plan if accepted would be to change all the ListViews to RecyclerView or atleast the performance intensive ones. If we indeed decide to change to RecyclerView then it would be better to hold this one up.
I don't believe fastbar is needed at the moment and we have another issue open looking into that. As for nightmode you have created another issue so closing as duplicate of #552.
Is it a ?
[ ] Bug Report
[x] Feature Request
Bug Report
Step 1: Are you ready to report?
Step 2: What is your environment?
Step 3: Describe the problem:
What do you obtain? A copy of the error message or a screenshot is always useful.
When does this occur? 1- When we click on the globe to open the language section, there is no scroll bar(fastscroll) which can be touched and scrolled around the list,it is quite difficult without it as the list is long,this problem is everywhere where lists are used in the application 2 - In night mode the language section checkbox to select language are almost invisible because of its color,we can change it to white color in night mode
Steps to reproduce:
__In library click on Globe symbol(language section)___
_ We cannot move through the list with help of scrollbar like in fastscroll___
__Turn on the night mode___
Go to the language Section[same steps as above] the check box are not that visible becuase of its color
What should be the behaviour from your point of view? How do you expect the service to work? FastScroll should be enabled wherever listviews are used and the color of checkbox should be changed in night mode
Step 4 (optional) : Other Comments:
What is the context of this ticket? If not obvious, explain why you need to do this.
If you have an idea about the technical background of the ticket, please share it.
Feature Request
Feature Description
Please describe the feature you want to add to the project.
I would like to work on it,Ill add the scroller on all the list views and change the color of the checkbox