Icons are clumped together in RTL global search

kiwix / kiwix-android

Kiwix for Android

https://android.kiwix.org

GNU General Public License v3.0

826 stars 443 forks source link

Icons are clumped together in RTL global search #582

Closed RohanBh closed 5 years ago

RohanBh commented 6 years ago

Bug Report

Are you ready to report?

Yes

Environment

version of the software you use: v2.3 Build 55
device / operating system: oneplus 3, Android 8.0

The Bug:

In LTR searching, back arrow and the cross are opposite to each other. But, in RTL searching, both of these icons clump together in the left corner. LTR RTL

Steps to reproduce:

Enable Force RTL option from developer settings on your device.
Type something in the global search bar.

Expected behavior: The icons must be at the opposite ends in RTL searching too.

I am working on this.

RohanBh commented 6 years ago

@mhutti1 I have fixed this issue. But currently, search activity crashes when it opens in the master branch. Can you please take a look at this PR which fixes the crash, so that I can create a PR for this issue. Also, the work that is done in this PR so less. I was wondering if I can make a PR that fixes #365 as well since they are related.

mhutti1 commented 6 years ago

give @Koundinyalanka one more day then you can be reassigned.

RohanBh commented 6 years ago

Can I be assigned #365 now @mhutti1?

kelson42 commented 6 years ago

@RohanBh Any news on this?

RohanBh commented 6 years ago

@kelson42 I was busy with a project for this college fest this week. I have made a PR now fixing the assigned issues. Sorry for the delay.