search

kiwix / kiwix-apple-custom

GNU General Public License v3.0
2 stars 2 forks source link

Use full URL in info.json files for custom apps #10

Closed BPerlakiH closed 10 months ago

BPerlakiH commented 10 months ago

The problem

In the current info.json files we cannot use a full URL. The reason for this, is that in .xcconfig files slashes are not parsed correctly.

Solution

Actually we can bypass this now. Currently these custom app values go from: info.json -> dwds.xcconfig as a variable, that variable goes into the dwds.plist file.

At the moment all the custom .plist files are essentially identical, but we can move the actual value from info.json to the custom .plist file, this way we won't have the limitations that the xcconfig file format has, so we can use a full url.

Requires updating both the info.json and the kiwix/apple repo.

BPerlakiH commented 10 months ago

This has been implemented, and merged