Closed BPerlakiH closed 9 months ago
@BPerlakiH @rgaudin Maybe I got that wrong, but I though we agreed that the whole version comes from the tag?!
@kelson42 I think we can change it to be the whole version. We can validate against the brand folder name and the URL / file name (ending) contained in the info.json.
I've updated the code, now it is validating against the brand folder, and the date that is in the URL. A valid tag now looks like the following ones:
ect. There are also reasonable error messages added, such as:
dwds_2033.03.02
Error: Invalid tag dwds_2033.03.02: invalid year: 2033
dwds_2023.13.02
Error: Invalid tag dwds_2023.13.02: invalid month: 13
dwds_2023.03.02
Error: Invalid date in tag: dwds_2023.03.02, does not match year.month of ZIM file in dwds/info.json, it should be: 2023.12.2
dwds_2023.03.189
Error: Invalid date in tag: dwds_2023.03.189, does not match year.month of ZIM file in dwds/info.json, it should be: 2023.12.189
dds_2023.03.189
Error: Invalid tag dds_2023.03.189: The directory for brand: 'dds' does not exist
> mkdir wiki
wiki_2023.03.189
Error: Invalid tag wiki_2023.03.189: There is no info.json file for brand 'wiki'
@kelson42 @rgaudin it has been implemented, and tested with this tag/release: https://github.com/kiwix/kiwix-apple-custom/actions/runs/7514404208
@BPerlakiH Good, but where is the code to review?
It has been merged into kiwix/kiwix-apple-custom main branch.
We want to build and deliver custom apps via a manual trigger, similar to
kiwix/kiwix-android-custom
. Assumptions:build_number
should be taken from the tag we create on the releasebuild_number
twice (we might need to restart or overwrite the build), any additional parts can be appended to tags.main
branch), containing aninfo.json
file.