search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
87 stars 42 forks source link

Add flake8 check #263

Open refeed opened 5 years ago

refeed commented 5 years ago

kiwix-build mainly comprises of Python codes, I think it'd be nice if this repository had a flake8 (which checks for codestyle and possible errors and bug (such as unused var, etc)) check in its Travis-CI.

kelson42 commented 5 years ago

@refeed Why not, would be be able to make a PR to introduce it?

refeed commented 5 years ago

@refeed Alright, I'm gonna make a PR for it

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

HimanshuMahto commented 1 year ago

is it still open if then i would like to work on it.

kelson42 commented 1 year ago

@HimanshuMahto yes you can

Rayan-Rasheed commented 1 year ago

Is this issue still open? Because I want to work on it.

kelson42 commented 1 year ago

@mgautierfr ?

mgautierfr commented 1 year ago

The issue is still open. But I strongly suggest that @Rayan-Rasheed and @HimanshuMahto discuss together before doing both the same work. On my side I don't care about who does it. I will review the first PR coming (and accept the first acceptable one). I don't which to review to almost identical PR.

Vishnurr2k01 commented 6 months ago

is this issue still available ?

mgautierfr commented 5 months ago

Yes.