search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
90 stars 43 forks source link

Add macOS_arm64_mixed platform. #584

Closed mgautierfr closed 1 year ago

mgautierfr commented 1 year ago

Fixes #570 Fixes #511

kelson42 commented 1 year ago

@mgautierfr I have put two ticket numbers fixed by this PR. I hope this is correct because I'm unsure. Please verify with the whole list of open tickets to check if I don't have missed other one.

In general, please put the tickets concerned by your PR early, so everybody understand what is going one and act accordingly.

kelson42 commented 1 year ago

@mgautierfr What is the status here?

mgautierfr commented 1 year ago

I think it is ok. But this is not tested (at leas by me)

kelson42 commented 1 year ago

@mgautierfr Do we know how the output looks like? Where is that? Or should we merge to see?

mgautierfr commented 1 year ago

Output is here : https://tmp.kiwix.org/ci/macos_arm64/

And it (libzim archive) looks good.

kelson42 commented 1 year ago

Output is here : https://tmp.kiwix.org/ci/macos_arm64/

And it (libzim archive) looks good.

@rgaudin @automactic Does that look good to you? Is that in the correct form or do you need another kind of packaging?

rgaudin commented 1 year ago

It does ; I am testing it already before accepting. AFAIK, @automactic doesn't care for libzim.

mgautierfr commented 1 year ago

Let's merge it then.