search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
90 stars 43 forks source link

Libzim releases include the full libicu data #603

Closed kelson42 closed 12 months ago

kelson42 commented 1 year ago

… but actually we use only part of it. We should better release libzim only with a subset of it. This would allow to save many MBs is the libzim binary release.

kelson42 commented 1 year ago

This is something we do already on kiwix for Android.

mgautierfr commented 1 year ago

What we do for Android is packaging the data as a external file. But we use the same dataset in all our build. This data set is already patched : https://github.com/kiwix/kiwix-build/blob/main/kiwixbuild/patches/icu4c_custom_data.patch

This may be improved but I don't how/what to remove.

kelson42 commented 1 year ago

A few years ago, I was cutomizing the dataset, just using try and error. If the libicu relies on something which is not in the dataset, then it crashes.

mgautierfr commented 12 months ago

We have update to the last version of ICU, but a newly curated data.

As said, we use the same (curated) data for all our project. We only package the data differently depending of the platform.

I'm closing the issue. If there is something specific wrong, please open a new issue.