search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
91 stars 43 forks source link

Use libxapian 1.4.23 #627

Closed kelson42 closed 12 months ago

kelson42 commented 1 year ago

https://trac.xapian.org/wiki/ReleaseOverview/1.4.23

We shoudl be able to avoid https://github.com/kiwix/kiwix-build/pull/600/commits/5ef7e2a017dcfcfeb10ad376e9a8dcb5d7a37812#diff-195a8c5ae0484fec5d4b6a682644710a05e8756754472b73f44f7bca09993ad0R17

asryan11 commented 1 year ago

Hello, is this issue still open?

mgautierfr commented 1 year ago

This is still open yes. Do you want to do it ?

asryan11 commented 1 year ago

Yes, I want to do this. But I am new to open source can you just guide me on how to complete this or tell me where to start?

dilankavishka commented 1 year ago

Can i work on this issue plaese?

dilankavishka commented 1 year ago

please assign me to this issue

kshitiz305 commented 1 year ago

Which line do you wish to avoid in this .

We shoudl be able to avoid https://github.com/kiwix/kiwix-build/commit/5ef7e2a017dcfcfeb10ad376e9a8dcb5d7a37812#diff-195a8c5ae0484fec5d4b6a682644710a05e8756754472b73f44f7bca09993ad0R17

mgautierfr commented 1 year ago

By updating libxapian version, we should not need to have a custom patch.

If you (any of you) want to do it, simply do it and propose a PR. Don't ask how to do it, I would spend less time doing it myself :)