search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
87 stars 42 forks source link

Extend the build definition with P(ublish), S(ource), D(ocker) and platform_name. #630

Closed mgautierfr closed 1 year ago

mgautierfr commented 1 year ago

As the docker workflows builds for all supported platform, I'm afraid this may fail.

Ho, I missed that.

So the solution is probably to use a specific job in the workflow to trigger the workflow and add dependencies between jobs (https://docs.github.com/en/actions/using-jobs/using-jobs-in-a-workflow#example-requiring-successful-dependent-jobs)

Edit: and with a github action as https://github.com/marketplace/actions/trigger-ci it would be pretty straightforward to do (and we could remove all the corresponding python code)

mgautierfr commented 1 year ago

Last commit move docker triggering at the end of all other jobs. I don't use a github action as we need to pass the version as input and so we need to access the python code and such.

mgautierfr commented 1 year ago

Be careful, releaseNightly workflow is not run on PR. So CI doesn't help us to check the validity of the change.