search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
87 stars 42 forks source link

Update emsdk version. #637

Closed mgautierfr closed 10 months ago

kelson42 commented 10 months ago

@mgautierfr Does something stop us to merge this?

mgautierfr commented 10 months ago

It was a test to fix https://github.com/openzim/libzim/issues/828. I don't know how it impacts kiwix-js (@Jaifroid ?)

Jaifroid commented 10 months ago

Well, we can build from source using EMSDK v3.1.41, and we also build the libzim.a version using 3.1.41, so it would make sense for us to be in sync on the version. It should work with about 90% certainty (just because there can always be something unexpected), and I guess we'd find out soon enough if it doesn't...