Update Apple Platforms - Githubissues

kiwix / kiwix-build

Kiwix & openZIM build engine

GNU General Public License v3.0

91 stars 43 forks source link

Update Apple Platforms #638

Closed automactic closed 11 months ago

automactic commented 1 year ago

Removed MacABI (aka UIKit on Mac, it is not needed)
5 targets -- iOS_arm64, iOS_simulator_x86, iOS_simulator_arm64, macOS_arm64, macOS_x86
added mmacosx-version-min and mmacosx-version-min in various places
update min os version to macOS 12.0 & iOS 15.0

automactic commented 1 year ago

As far as I can tell, the kiwix-build commands did succeed. But there are a bunch of other stuff going on after the build command, which I am not very familiar with... And something post build is failing

kelson42 commented 1 year ago

@mgautierfr Can you please have a look?

mgautierfr commented 1 year ago

Haven't had a close look, but it missing at least a change in the build definition

(That's why https://github.com/kiwix/kiwix-build/actions/runs/6575114946/job/17861547005?pr=638)

Files in kiwixbuild/platforms/* define the platforms (ie, what compiler to use, which "global" options, ...)
Files in kiwixbuild/dependencies/* define how to build each project/dependency (ie, options specific to the build project)
Jobs definition in https://github.com/kiwix/kiwix-build/tree/main/.github/workflows defines what jobs we need to launch (ie, which platform to use)
https://github.com/kiwix/kiwix-build/blob/main/.github/scripts/build_definition.py defines what to build in each job.

mgautierfr commented 1 year ago

This PR also show a usage of c++ feature deprecated in c++17 in zim-tools. This is fixed in https://github.com/openzim/zim-tools/pull/376

kelson42 commented 1 year ago

I'm not in favour to abandon support of macOS11 for libzim without clear reason. Libzim bindings should better stay compatible with older versions of macOS as long as it does not create serious problems.

Having a ticket explaining why we do things would be helpful. PR without corresponding issues should be avoided or kept for very trivial changes.

automactic commented 1 year ago

I'm not in favour to abandon support of macOS11 for libzim without clear reason. Libzim bindings should better stay compatible with older versions of macOS as long as it does not create serious problems.

@kelson42 Hey, are there anyone else that needs libzim on macOS 11? If I (i.e. kiwix for macOS and iOS app) is the only one, then that might be a good reason to no longer support macOS 11, since the kiwix app does not support macOS 11.

mgautierfr commented 1 year ago

We are in https://github.com/openzim/python-libzim

kelson42 commented 12 months ago

@automactic @mgautierfr @rgaudin We are in an almost emergency situation to move forward on Apple custom apps. This is TOP PRIO that we CI+CD for libzim and libkiwix for both macOS and iOS work ASAP. Therefore this PR should be on the very TOP of the agenda.

kelson42 commented 12 months ago

After discussion with @rgaudin regarding the min macOS version, we agreed:

We will use the rule applied for Kiwix for macOS/iOS which is -2 major macOS version supported
Which has directly consequence, that from now, min macOS supported (and on which we compile) is macOS 12

I will update the CI/CD.

kelson42 commented 11 months ago

Probably superseeded by #650.

kelson42 commented 11 months ago

Superseeded by #653