search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
87 stars 42 forks source link

Build zim-tools and kiwix-tools on macos-arm64 #649

Closed mgautierfr closed 10 months ago

mgautierfr commented 10 months ago

Fix #593 Fix #592

mgautierfr commented 10 months ago

@rgaudin Can you try https://tmp.kiwix.org/ci/dev_preview/tools_on_macos_m1/kiwix-tools_macos-arm64-2023-11-07.tar.gz and https://tmp.kiwix.org/ci/dev_preview/tools_on_macos_m1/zim-tools_macos-arm64-2023-11-07.tar.gz ?

This PRĀ removes the -fembed-bitcode option. I don't know the implication but it is also removed in #638 so I suppose we are ok.

rgaudin commented 10 months ago

Both work fine (tested kiwix-serve and zimcheck) šŸ‘

Indeed, as explained, we want to remove bitcode from now

mgautierfr commented 10 months ago

Rebased on #638 to use the changes made there.

kelson42 commented 10 months ago

@mgautierfr Is that ready to review by @rgaudin?

mgautierfr commented 10 months ago

@mgautierfr Is that ready to review by @rgaudin?

It is, but the PRĀ is really simple, most of the job has been made in #638. I'm merging directly.