search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
87 stars 42 forks source link

Publish projects deps in branch-named folder when outside of main #651

Closed mgautierfr closed 10 months ago

mgautierfr commented 10 months ago

Still publish the deps in the dep_previews directory in case we would like to test it project's CI.

This should avoid conflict (and broken CI) when we try things on kiwix-build CI.

kelson42 commented 10 months ago

This should always have been like this and should really stay like this. Our CI pipelines are far too instable and measures should be taken and respected to fix this recurring problem.

mgautierfr commented 10 months ago

I totally agree with you.

But, for a bit of context:

This never was like this. And it was extremely useful to check that PR on kiwix-build will actually create dependency archives which can be used on projects' CI (just have to relaunch a workflow on the project CI and see if it breaks) If somehow the PR is broken, we just had to wait for the nightly workflow to run to reset the dep archives to the working (main) version.

We the "recent" introduction of publishing dev preview in dev_preview, we now have a place to also publish preview of our dependency archives.

However, to test that deps archives are ok, we now have to create a (not intended to be merged) PR on projects side with a temporary commit switching from downloading "main" dep archive to downloading custom "dev_preview" dep archive.