Closed rgaudin closed 8 months ago
@rgaudin Thank you very much, yes we should make a new built of libkiwix13 or release 13.0.1.
OK will do ; recreating base deps 95 now as it doesn't include the new names
OK it's now all green ; pushing again to resolve the fixup. We're good to merge
The today nightly has failed on macos apple_all_static (https://github.com/kiwix/kiwix-build/actions/runs/7094928431/job/19311027499).
It is potentially related to this PR which may (if you have deleted them) have recreate base_deps2_*
archives.
The today nightly has failed on macos apple_all_static (https://github.com/kiwix/kiwix-build/actions/runs/7094928431/job/19311027499). It is potentially related to this PR which may (if you have deleted them) have recreate
base_deps2_*
archives.
That's expected. I had to delete 96 and recreate it (in this PR) so it includes the new name. As you can see in the log, it lacks BUILD_iOS_x86_64
which is the former name of the iOSSimulator_x86_64
platform-target
Would have been better to change the base_deps_version to 97 to avoid such conflict (for the next time). But we are good. I'm merging.
When we introduced CoreKiwix.xcframework, we made two mistakes:
x86_64-apple-ios
target thinking simulator is a “just” an iOS on x64This target mistake prevented XCode from finding our lib usable with the Simulator on x64. Not including an arm64 version obviously prevented Silicon-using devs from using the Simulator.
The included libs changes now from
ios-arm64
ios-x86_64-simulator
macos-arm64_x86_64
To
ios-arm64
ios-arm64_x86_64-simulator
macos-arm64_x86_64
Changes
iOSx64
Platforn renamed toiOSx64Simulator
with its target fixed tox86-apple-ios-simulator
(wasx86_64-apple-ios
)iOSArm64Simulator
for Apple Silicon devs to run SimulatorAppleXCFramework
dependency gets two changes: - Depends on all those platforms -_make_macos_fat()
turned generic and called both for macOS fat binary and iOS Simulator oneFixes #667
Note: this may require a new build of the libkiwix 13.0.0 release. @kelson42 WDYT?