search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
86 stars 42 forks source link

Explicit dependence names for macOS #677

Closed kelson42 closed 2 months ago

kelson42 commented 6 months ago

Currently with use native_xyz for macOS dependencies (filenames) for macOS binaries, but now that we want to compile on both M1 and x86_64, we need to be explicit. Otherwise no clue about what we are talking about and we get "unclear" error message later. See https://github.com/openzim/libzim/pull/856

BTW, target names for Apple platform are in both CI and CD with uppercase, this seems wrong.

kelson42 commented 4 months ago

@mgautierfr What is the status here?

kelson42 commented 3 months ago

@mgautierfr Does #689 has fixed this issue?

mgautierfr commented 2 months ago

Fixed indeed.