kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
86 stars 42 forks source link

Forcefully adding libthai.so to kiwix-desktop appimage #693

Closed veloman-yunkan closed 3 months ago

veloman-yunkan commented 4 months ago

Should fix kiwix/kiwix-desktop#1016

linuxdeployqt (the tool used for creating the kiwix-desktop appimage) doesn't put libthai.so into the appimage as that library has caused problems in the past. The entry for libthai.so in the respective "blacklist" reads:

libthai.so.0
# Workaround for:
# audacity: /tmp/.mount_AudaciUsFbON/usr/lib/libthai.so.0: version `LIBTHAI_0.1.25' not found (required by /usr/lib64/libpango-1.0.so.0)
# on openSUSE Tumbleweed

I verified that the fix produces an appimage that works on an Ubuntu 22.04 system with the libthai.so* files temporarily removed from /usr/lib/x86_64-linux-gnu whereas the official release appimage reports the same error as described in kiwix/kiwix-desktop#1016 and doesn't start:

./kiwix-desktop_x86_64_2.3.1-4.appimage: error while loading shared libraries: libthai.so.0: cannot open shared object file: No such file or directory

The (fixed) appimage also works without problem on an unmodified Ubuntu 22.04 (of course, assuming that kiwix/kiwix-desktop#871 doesn't count in the context of this PR).

Note however that I didn't try running the appimage on a system that contains a drastically different version of libthai.so - under both Ubuntu22.04 (jammy) which I used for testing and Ubuntu 20.04 (focal) on which I built the appimage the shared library file (in /usr/lib/x86_64-linux-gnu) is named libthai.so.0.3.1 although jammy's package version for libthai0 strangely reads 0.1.29-1build1 while for focal it's 0.1.28-3.

mgautierfr commented 4 months ago

under both Ubuntu22.04 (jammy) which I used for testing and Ubuntu 20.04 (focal) on which I built the appimage the shared library file (in /usr/lib/x86_64-linux-gnu) is named libthai.so.0.3.1

Same on my Fedora 39

@Yanestra can you test https://tmp.kiwix.org/ci/dev_preview/kiwix-desktop-appimage-libthai_so/kiwix-desktop_x86_64_2024-04-19.appimage ?

kelson42 commented 3 months ago

@mgautierfr @veloman-yunkan Can we merge this now?