kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
88 stars 42 forks source link

Use gz compression for deps archive. #716

Closed mgautierfr closed 1 month ago

mgautierfr commented 1 month ago

It is a bit of memory waste but a lot of time win (at least on android build)

kelson42 commented 4 weeks ago

Would have been nice to update all projects as well, because this PR has broken all the CI/CD (relying on cutting-edge features of dependencies)

EDIT: dist file has not been updated!

mgautierfr commented 4 weeks ago

Arf, that is why I wanted to not have a freezed version but always use the main version for the dl_deps_archive action.

mgautierfr commented 4 weeks ago

It seems only libzim is impacted, other project already use the main version. PR is https://github.com/openzim/libzim/pull/911

kelson42 commented 4 weeks ago

It's not! Even main rely on the dist version looks like! https://github.com/kiwix/kiwix-desktop/pull/1175, as long

mgautierfr commented 4 weeks ago

Indeed, I have forget to generate the dist version. Fixed by #718