Do not use base_deps when building releases.

kiwix / kiwix-build

Kiwix & openZIM build engine

GNU General Public License v3.0

88 stars 42 forks source link

Do not use base_deps when building releases. #739

Closed mgautierfr closed 2 weeks ago

mgautierfr commented 2 weeks ago

Initially we were building all our dependencies in release. This was simply made by always compiling project using autotool or cmake in release. As our project are using meson/qmake, all the dependencies are build in release.

However, with recent port to Windows github CI, we have two problems:

We have moved almost all buildsystem to meson
On Windows, we cannot mix debug and release build.

So, when doing a release, do not use base dependencies cache. This will extend the release workflow as we need to build everything but at least we should build everything correctly.

mgautierfr commented 2 weeks ago

Fix #738

kelson42 commented 2 weeks ago

The risk of having CI, nightlies and releases working differently will be a potential source of instability. Considering the overall high instability of the system, I'm worried about that move and its consequences... But I'm not able to assess it properly right now.

mgautierfr commented 2 weeks ago

I understand your point (and share it under a certain point).

But they are doing different things, so they have to work differently. We can probably share more but at the end we will have different things:

CI (which also run nightly) compile more architectures and build dependencies for other projects
Release build released (only) projects on less architectures, and publish sources.
Nigthly (which already share the same workflow than release) build all projects (on same architectures than release), in debug and publish them under different name/directory than release.

Anyway, this is a issue in itself and not related to this PR. So I'm merging.