search

kiwix / kiwix-build

Kiwix & openZIM build engine
GNU General Public License v3.0
90 stars 43 forks source link

Disable DEBUG for Windows nightly #757

Open rgaudin opened 1 month ago

rgaudin commented 1 month ago

⚠️ It's at the frontier of bug/feature.

On Windows, binaries cl-compiled with _DEBUG require the debug version of the runtime libraries (MSVCRT).

Currently, our nightlies use _DEBUG and thus require nightly users to install specific development tools to use them.

After discussing it with @kelson42 it appears nightlies main role is to allow power users to test the current state of projects and is not a developer/debug tool.

We should thus remove _DEBUG from nightlies.

What it entails is unclear at this stage ; this is in reaction of testing a kiwix-desktop. I dont know the state of shared dependencies.

On kiwix-desktop, at least there is:

        @property
        def make_targets(self):
            if platform.system() == "Windows":
                yield "release-all" if option("make_release") else "debug-all"
            else:
                yield from super().make_targets

        @property
        def make_install_targets(self):
            if platform.system() == "Windows":
                yield "release-install" if option("make_release") else "debug-install"
            else:
                yield "install"
kelson42 commented 2 days ago

@veloman-yunkan This impact I believe all the repositories and make the nightly buiilds almost totally unusable. Do you believe this is easily fixable?