search

kiwix / kiwix-desktop

Kiwix for Windows and GNU/Linux desktops
https://download.kiwix.org/release/kiwix-desktop/
GNU General Public License v3.0
776 stars 101 forks source link

Do Not Save Translation for Filters in Settings Session #1185

Closed ShaopengLin closed 2 months ago

ShaopengLin commented 2 months ago

From #1175 comment

  1. We should only need to store a list of strings, the filter keys, in the session. The problem comes with backward compatibility as the previous sessions are now invalid. Need to discuss how to best approach this issue.

  2. KiwixChoiceBox needs to adapt to the new session management.

kelson42 commented 2 months ago

@ShaopengLin If you don't migrate, the only problem is that people will loose once their categorisation filters, just after software upgrade, right? To me I don't really understand why we should not implement straight this in a PR. Seems trivial.

ShaopengLin commented 2 months ago

@kelson42 @veloman-yunkan if we are ok with that one time lost, then indeed we can make this change directly. This then should come with #1175, as it will not introduce a huge detour. If you all agree could you close this? I will make the modification back over at #1175.

veloman-yunkan commented 2 months ago

Fixed by #1175