search

kiwix / kiwix-desktop

Kiwix for Windows and GNU/Linux desktops
https://download.kiwix.org/release/kiwix-desktop/
GNU General Public License v3.0
776 stars 101 forks source link

New implement search in tabs/history/bookmarks #1194

Open kelson42 opened 2 months ago

kelson42 commented 2 months ago

Following #413

image

kelson42 commented 1 month ago

See also https://github.com/kiwix/kiwix-desktop/pull/1189#issuecomment-2382982580

ShaopengLin commented 1 week ago

@veloman-yunkan Working at #1237 makes me think using QTree/ListWidget might can make it easier to solve issue. Since QTree/ListWidget inherits from Views, it can be set as the view in QCompeleter. We can then simply add different suggestion views into the QTree/ListWidget.

The main problem would be how to correctly handle the different models, as well as dealing with QCompleter's selection and completion. I would expect this to be a huge change (again).

Also, I do not recommend replacing the existing view with QTreeWidget, simply due to endless search creates a very large list and QTreeWidget is known to be very bad at handling huge data amounts. (Originally why I decided to not use QTree/ListWidget.)

Just food for thought, in case the discussion we had back in #1189 doesn't hold.