search

kiwix / kiwix-desktop

Kiwix for Windows and GNU/Linux desktops
https://download.kiwix.org/release/kiwix-desktop/
GNU General Public License v3.0
777 stars 102 forks source link

Issues when opening zim file #1206

Closed sgourdas closed 2 months ago

sgourdas commented 2 months ago

Several issues come up in the terminal when opening zim files inside the app.

Example:

js: Uncaught SyntaxError: Unexpected token .
js: Uncaught TypeError: Cannot read property 'classList' of undefined
js: Uncaught ReferenceError: $ is not defined
js: JQMIGRATE: jQuery is not compatible with Quirks Mode
js: Uncaught ReferenceError: mw is not defined
js: Uncaught ReferenceError: mw is not defined
js: Uncaught TypeError: Cannot read property 'classList' of undefined
js: Uncaught SyntaxError: Unexpected end of input
js: Uncaught SyntaxError: Unexpected token .
js: Uncaught TypeError: Cannot read property 'classList' of undefined
js: Uncaught ReferenceError: $ is not defined

We should look into these.

kelson42 commented 2 months ago

They are javascript errors linked to the content itself. This is a known problem with MWoffliner based (Wikipedia) ZIM files. I don't think there is anything we could/should do here in Kiwix Desktop.

sgourdas commented 2 months ago

I mean, from the every day user side isn't this an issue though? Because there can be a zim available that does not render a page at all. Should/Can we do something like a form of verification for the content we can serve appropriately?

kelson42 commented 2 months ago

@sgourdas No it's not really.