search

kiwix / kiwix-desktop

Kiwix for Windows and GNU/Linux desktops
https://download.kiwix.org/release/kiwix-desktop/
GNU General Public License v3.0
777 stars 102 forks source link

Fix network share launch popup #1215

Closed sgourdas closed 2 months ago

sgourdas commented 2 months ago

This fixes the faulty implementation of the popup asking the user if he wants to use the app with no sandbox, when launched from a Windows network share.

Now, in such case, the sandbox will be disabled automatically, the app will start and then prompt the user if he wants to proceed acknowledging the fact.

Fixes #885

kelson42 commented 2 months ago

@sgourdas Please change the message to "Kiwix has been launched from a network drive. This is known to cause compatibility issues with the browsing sandboxing. As a result, the sandbox will be disabled. Do you want to continue?"

For the rest fine to me, @veloman-yunkan ready to code review.