Allow to build with packaged version of qtsingleapplication

[xvitaly]

Bundling is strictly forbidden in lots of GNU/Linux distributions. Please add ability to build with packaged version of qtsingleapplication.

[xvitaly]

Regression introduced in #424.

[xvitaly]

Fixed on our side by adding CONFIG+=qtsingleapplication to qmake-qt5.

[kelson42]

@xvitaly @mgautierfr I guess if the ticket is closed there is nothing to do on our end. I don't really understand the ticket.

[xvitaly]

I guess if the ticket is closed there is nothing to do on our end. I don't really understand the ticket.

I'm Kiwix Desktop Fedora GNU/Linux package maintainer. On Fedora we cannot use bundled dependencies, that's why we must unbundle all of them.

I fixed this issue on our side by removing the subprojects/qtsingleapplication directory and passing the CONFIG+=qtsingleapplication parameter to qmake-qt5 build tool.

[kelson42]

@xvitaly Thank you. I reopen the ticket because I don't understand why we don't do that upstream!

[xvitaly]

Thank you. I reopen the ticket because I don't understand why we don't do that upstream!

We also need to patch .pro file to remove /static option and remove git calls:

sed -e "/static {/,+2d" -e "/git describe/c\DEFINES += GIT_VERSION='%{version}'" -e "s/shell date/shell date +\%G-\%m-\%d/g" -i %{name}.pro

I would appreciate if it can be fixed in upstream.

[kelson42]

@xvitaly We will have a look, the ideal solution would be to build the Fedora packages within our CI so we can:

• Provide cutting-edge/testing RPM packges
• Secure upstream (at the source) that we won't have problems later.

This is an approach we are following for Deb packages (Debian/Ubuntu) and that I would be happy to see as well with Fedroa RPMs.

[xvitaly]

We will have a look, the ideal solution would be to build the Fedora packages within our CI so we can:

Fedora already has Kiwix Desktop (and kiwix-lib, kiwix-tools, libzim) in the official repositories.

This is an approach we are following for Deb packages (Debian/Ubuntu) and that I would be happy to see as well with Fedroa RPMs.

If you want to build Fedora packages for testing purposes on CI, feel free to take SPECs from Fedora:

• kiwix-desktop;
• zimlib;
• kiwix-lib;
• kiwix-tools.

If you have any question about Fedora packaging, I can help with this.

[legoktm]

Unfortunately Debian doesn't have qtsingleapplication packaged yet (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641812), so we would prefer to have it bundled along for now if that's alright...

[kelson42]

@legoktm Good to me.

[legoktm]

We also need to patch .pro file to remove /static option and remove git calls:

sed -e "/static {/,+2d" -e "/git describe/c\DEFINES += GIT_VERSION='%{version}'" -e "s/shell date/shell date +\%G-\%m-\%d/g" -i %{name}.pro

I would appreciate if it can be fixed in upstream.

I filed #476 for this.

[kelson42]

@legoktm @xvitaly @mgautierfr If I understand properly here we should make a kind of qmake/make option to be able to call the build process without using the local "qtsingleapplication"? Or the other way around (not sure what is the best default behaviour)?

[kelson42]

@xvitaly @legoktm BTW, I hope you have seen that we have introduced feed.xml in https://download.kiwix.org/release and https://download.openzim.org/release, so you can immediatly be informed when a new release has been made.

[legoktm]

Unfortunately Debian doesn't have qtsingleapplication packaged yet (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641812), so we would prefer to have it bundled along for now if that's alright...

I asked the Debian Qt maintainers for assistance/recommendations: https://lists.debian.org/debian-qt-kde/2020/07/msg00051.html

[xvitaly]

If I understand properly here we should make a kind of qmake/make option to be able to call the build process without using the local "qtsingleapplication"? Or the other way around (not sure what is the best default behaviour)?

An additional build option looks good for me.

BTW, I hope you have seen that we have introduced feed.xml in https://download.kiwix.org/release and https://download.openzim.org/release, so you can immediatly be informed when a new release has been made.

Good, thanks. But I prefer GitHub release subscriptions on email.

[kelson42]

BTW, I hope you have seen that we have introduced feed.xml in https://download.kiwix.org/release and https://download.openzim.org/release, so you can immediatly be informed when a new release has been made.

Good, thanks. But I prefer GitHub release subscriptions on email.

We release most of the time based on a tag but I heard we could request similarly to release based on Github release event... Currently under investigation the pros/cons.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.