search

kiwix / kiwix-js-pwa

Kiwix JS Offline Browser implemented as a Progressive Web App (PWA), and packaged as Electron, NWJS and UWP apps for Windows and Linux.
https://pwa.kiwix.org
GNU General Public License v3.0
189 stars 31 forks source link

DarkReader plugin seems to disrupt some UTF8 hyperlinks #319

Open Jaifroid opened 1 year ago

Jaifroid commented 1 year ago

This is a weird one. When accessing wikihow_fa_maxi_2022-09.zim, in the PWA or Electron apps, the links on the landing page in Farsi script work fine in light mode or in the standard / inverted dark mode, but if I use the DarkReader plugin, the app reports that it is unable to find the corresponding article when clicking on the exact same links. It would be very surprising if the DarkReader JS is altering the UTF8 in some way, but something fishy is happening. Needs investigating.

s-pratik commented 1 year ago

Hii, I would like to contribute I am a beginner here can you tell me how can i get started?

Jaifroid commented 1 year ago

@s-pratik Thank you for the offer. However, if you're a beginner, then I think this issue is not straightforward. You might consider instead one of the "Good first issues" from the upstream version of this Repo, here: https://github.com/kiwix/kiwix-js/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22. If any of those interest you, ping me on the issue you're interested in.