kiwix / kiwix-js-pwa

Kiwix JS Offline Browser implemented as a Progressive Web App (PWA), and packaged as Electron, NWJS and UWP apps for Windows and Linux.
https://pwa.kiwix.org
GNU General Public License v3.0
187 stars 31 forks source link

When setting dark mode, set it to on before setting it to auto #524

Closed Jaifroid closed 9 months ago

Jaifroid commented 10 months ago

Currently there is a tri-state checkbox: one click sets dark mode to auto, the second click sets it to always on, and the third click turns it off again. However, if the user's OS is in light mode, it may appear to the naive user that the darkmode setting doesn't work, because a single click will set the tick-box to auto and... nothing will happen. As most users don't read any instructions provided, it's a fair bet many will not think to click again, despite on-screen explanations.

To mitigate against this, it would be better to turn on when clicked once, and for auto to be the result of a second click, as this is for more sophisticated users.