kiwix / kiwix-js-pwa

Kiwix JS Offline Browser implemented as a Progressive Web App (PWA), and packaged as Electron, NWJS and UWP apps for Windows and Linux.
https://pwa.kiwix.org
GNU General Public License v3.0
168 stars 26 forks source link

Lack of synchronization of dark theme controls #608

Closed Jaifroid closed 2 months ago

Jaifroid commented 2 months ago

This issue only affects the UWP app, but it's annoying. The controls to set the dark theme have a convenience feature whereby they are cycled through merely by clicking the top control, which acts as a master. However, at least in EdgeHTML, the change event doesn't fire for tristate checkboxes when switching from auto to off. This descynchronizes the state of the controls, leading to confusing outcomes.

The simple solution is to use the click event instead of the change event for all the tristate controls.