Adapt to major changes in stylesheets and content layout with new mobile html endpoint Wikimedia ZIMs

kiwix / kiwix-js-pwa

Kiwix JS Offline Browser implemented as a Progressive Web App (PWA), and packaged as Electron, NWJS and UWP apps for Windows and Linux.

https://pwa.kiwix.org

GNU General Public License v3.0

191 stars 32 forks source link

Adapt to major changes in stylesheets and content layout with new mobile html endpoint Wikimedia ZIMs #629

Open Jaifroid opened 3 months ago

Jaifroid commented 3 months ago

The switch in mwOffliner to the new mobile html endpoint means that there are significant layout changes, as well as changes to bundled stylesheets. This has effects in the PWA (and WikiMed / Wikivoyage) apps, because the override stylesheets included to switch between mobile and desktop styles are only partially working. Additionally, override code for fixing the details-summary tags needs to be adapted.

None of this is impossible, but it is time-consuming to adjust.

Jaifroid commented 3 months ago

This issue is fixed for Wikivoyage ZIMs with https://github.com/kiwix/kiwix-js-pwa/commit/54c7142668a60516c8b4335384da796fcd33a920 and https://github.com/kiwix/kiwix-js-pwa/commit/292813439352b302cfb84eb495bdcc07da485472. Remaining to do is:

Transformation to Desktop style
Testing on non-Wikivoyage ZIM types, when we have such ZIMs

Jaifroid commented 3 months ago

Transform to desktop now fixed with https://github.com/kiwix/kiwix-js-pwa/commit/eb2222eb23feb43d355f5f6dbad97f9b85b939a6.

Jaifroid commented 3 months ago

All issues are currently fixed, but we don't have the final format of Wikimedia ZIMs scraped with the mobile-html REST API, so I'll leave open to monitor.