search

kiwix / kiwix-js-pwa

Kiwix JS Offline Browser implemented as a Progressive Web App (PWA), and packaged as Electron, NWJS and UWP apps for Windows and Linux.
https://pwa.kiwix.org
GNU General Public License v3.0
176 stars 29 forks source link

Algorithm that notifies users that a new GitHub update of Wikivoyage is available thinks 3.3.6 > 3.3.10 #631

Open Jaifroid opened 1 month ago

Jaifroid commented 1 month ago

This means users will be incorrectly notified that there is an update (fortunately it's a silent but quite visible notification at the top of Configuration) that there is an "update" version 3.3.6, when in fact that is the previous version.

Clearly it is doing an arithmetic "greater than" instead of a semantic "greater than". Grrr.

I can probably fix this by deleting or unpublishing (for now) v3.3.6, as I can't now update the code of 3.3.10 (which is released).

Either I avoid releasing versions with minorVersion > 9, or else I fix the algorithm to use a semantic comparison (I'm sure I have a bit of code somewhere in the app that has the required logic already, it's just not in the Electron update part). A fix would be better, if that code is under my control (I believe it is).

Jaifroid commented 1 month ago

There is no unpublish (convert to draft) for releases. So, I can either change the tag to 3.2.10, which will probably introduce some other weirdness with an out-of-sequence tag, or else I can just delete the previous release once the winget repository is updated to the latest (it's in certification).

Jaifroid commented 1 month ago

I confirm that deleting the previous release 3.3.6 prevents the update notification from appearing in 3.3.10. This is merely a workaround.